When compiling with LIBCXX_ENABLE_THREADS=NO, it still tries to include those, even though it doesn't need them.
I get away with not having the guard in <__mutex_base> because all the places where these two headers are used have:
#ifdef _LIBCPP_HAS_NO_THREADS #error <thread> is not supported on this single threaded system #else // !_LIBCPP_HAS_NO_THREADS
The one in mutex, I think, is a result of me not having rebased in a _long_ time, and the buildbot for it not testing exactly the same setup as me.
Sorry, I'm not sure I got what is the workflow on this platform. This patch is now "accepted", but do I need to do something else here? The only relevant action I can do seems to be "close revision", should I do that?
The developper policy page does not seem to indicate what to do after a patch has been accepted (or did I miss it?).
Ah, usually the process is that you get your patch through review, and when someone accepts it, then you can commit it. If you do not have commit rights, then you can get someone else to commit it for you.
Accepted => "ok to commit"
Closed => "I've committed it"
Do you need me to commit it for you?