This is an archive of the discontinued LLVM Phabricator instance.

[CUDA][HIP] Pass -fgpu-rdc to host clang -cc1
ClosedPublic

Authored by yaxunl on Feb 4 2021, 9:22 PM.

Details

Summary

Currently -fgpu-rdc is not passed to host clang -cc1.
This causes issue because -fgpu-rdc affects shadow
variable linkage in host compilation.

Diff Detail

Event Timeline

yaxunl requested review of this revision.Feb 4 2021, 9:22 PM
yaxunl created this revision.
tra accepted this revision.Feb 8 2021, 2:26 PM
tra added inline comments.
clang/test/Driver/hip-rdc-device-only.hip
50–61

At some point we should probably convert -SAME to -DAG so we don't have to shuffle the options around every time they change order.

This revision is now accepted and ready to land.Feb 8 2021, 2:26 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 4:09 PM