Page MenuHomePhabricator

Add SIE linux build bot
ClosedPublic

Authored by dyung on Jan 17 2021, 11:53 AM.

Details

Summary

This adds a linux build bot to the pool which builds/tests the PS4 triple on linux.

Diff Detail

Event Timeline

dyung requested review of this revision.Jan 17 2021, 11:53 AM
dyung created this revision.
dyung updated this revision to Diff 317509.Jan 19 2021, 3:31 AM
dyung added a project: Restricted Project.

Update removing some unneeded stuff.

gkistanova requested changes to this revision.Jan 22 2021, 12:02 AM

Please see my comments inline.

buildbot/osuosl/master/config/builders.py
104

I guess you mean collapsRequests here.

This would force to merge all build requests. For example, build requests for commits in the github with manual build requests. This is likely not what you really want. Better skip this parameter and let buildbot do its job, unless you know exactly what you are doing.

105

This should be workernames.

117

No need to specify -DLLVM_ENABLE_PROJECTS, it will be populated from depends_on_projects parameter.

This revision now requires changes to proceed.Jan 22 2021, 12:02 AM

Thanks, I'll update my patch with your suggestions. I think I was using an older template for the jobs which is why I was using outdated stuff. Sorry about that!

buildbot/osuosl/master/config/builders.py
104

Thanks for the explanation, I figured it collapsed all build requests, but didn't think that could possibly include manual build requests. I'll remove it as suggested.

dyung updated this revision to Diff 318441.Jan 22 2021, 12:28 AM

Updated patch with review feedback.

This revision is now accepted and ready to land.Thu, Feb 4, 8:22 PM