Page MenuHomePhabricator

[Sema] Proposed fix for PR 21837
AbandonedPublic

Authored by davide on May 1 2015, 5:07 PM.

Details

Reviewers
rjmccall
rsmith
Summary

https://llvm.org/bugs/show_bug.cgi?id=21837
I hit this recently and decided to investigate a little bit.
I'm still not 100% sure if we can arrive here with Access == AS_none, though.

Diff Detail

Event Timeline

davide updated this revision to Diff 24843.May 1 2015, 5:07 PM
davide retitled this revision from to [Sema] Proposed fix for PR 21837.
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added a reviewer: rsmith.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: Unknown Object (MLST).

FYI, Will add the testcase in the PR if this reviews actually goes anywhere.

davide added a comment.May 7 2015, 1:07 PM

Gentle ping.

rsmith added inline comments.May 12 2015, 2:10 PM
SemaAccess.cpp
1361–1362

Please add an assert that the Target is marked invalid here. I would also think that assuming invalid declarations are accessible is a better default; we don't want additional follow-on errors after the initial diagnostic that resulted in the entity being marked as invalid.

(And this comment also applies to the other change.)

Hrmm, the assertion you suggested to add (Target is marked invalid) fails, so I think this requires a different fix. I'll try to investigate futher over the next days.

davide abandoned this revision.Sep 9 2016, 1:44 PM