This is an archive of the discontinued LLVM Phabricator instance.

Differential D91782

[sanitizer] Fix SIGSEGV in fopen64 interceptor
AcceptedPublic

Authored by rayslava on Nov 19 2020, 4:15 AM.

Details

Reviewers
eugenis
Group Reviewers
Restricted Project
Summary

Interceptor causes SIGSEGV when null pointer is passed as path.

Diff Detail

Unit TestsFailed

TimeTest
500 mslinux > AddressSanitizer-x86_64-linux.TestCases::strcmp.c

Event Timeline

rayslava requested review of this revision.Nov 19 2020, 4:15 AM
rayslava created this revision.
Harbormaster completed remote builds in B79439: Diff 306366.Nov 19 2020, 4:42 AM
eugenis accepted this revision.Nov 19 2020, 12:54 PM
eugenis added a subscriber: eugenis.

LGTM

(please upload diffs with full context next time, see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)

This revision is now accepted and ready to land.Nov 19 2020, 12:54 PM

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 306366

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc

Context not available.
INTERCEPTOR(__sanitizer_FILE *, fopen64, const char *path, const char *mode) { INTERCEPTOR(__sanitizer_FILE *, fopen64, const char *path, const char *mode) {
void *ctx; void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, fopen64, path, mode); COMMON_INTERCEPTOR_ENTER(ctx, fopen64, path, mode);
COMMON_INTERCEPTOR_READ_RANGE(ctx, path, REAL(strlen)(path) + 1); if (path) COMMON_INTERCEPTOR_READ_RANGE(ctx, path, REAL(strlen)(path) + 1);
COMMON_INTERCEPTOR_READ_RANGE(ctx, mode, REAL(strlen)(mode) + 1); COMMON_INTERCEPTOR_READ_RANGE(ctx, mode, REAL(strlen)(mode) + 1);
__sanitizer_FILE *res = REAL(fopen64)(path, mode); __sanitizer_FILE *res = REAL(fopen64)(path, mode);
COMMON_INTERCEPTOR_FILE_OPEN(ctx, res, path); COMMON_INTERCEPTOR_FILE_OPEN(ctx, res, path);
Context not available.