Page MenuHomePhabricator

[InstCombine] Fold IntToPtr and PtrToInt into preceding loads.
ClosedPublic

Authored by philip.pfaffe on Apr 21 2015, 7:32 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

philip.pfaffe retitled this revision from to [InstCombine] Fold IntToPtr and PtrToInt into preceding loads..
philip.pfaffe updated this object.
philip.pfaffe edited the test plan for this revision. (Show Details)
philip.pfaffe added reviewers: majnemer, chandlerc.
philip.pfaffe set the repository for this revision to rL LLVM.
philip.pfaffe added a subscriber: Unknown Object (MLST).
chandlerc accepted this revision.May 27 2015, 2:33 AM
chandlerc edited edge metadata.

Looks good.

This revision is now accepted and ready to land.May 27 2015, 2:33 AM
majnemer added inline comments.May 27 2015, 3:04 AM
lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
486–487 ↗(On Diff #24132)

Your comment has mismatched parenthesis.

489 ↗(On Diff #24132)

Please fix the formatting here

philip.pfaffe edited edge metadata.
philip.pfaffe removed rL LLVM as the repository for this revision.

Rebased and addressed majnemer's comments.

majnemer accepted this revision.May 27 2015, 10:11 AM
majnemer edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.