This is an archive of the discontinued LLVM Phabricator instance.

Differential D91090

[lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes
ClosedPublic

Authored by mgorny on Nov 9 2020, 10:31 AM.

Details

Reviewers
krytarowski
Commits
rGed3ac6c110a5: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes
Summary

Fix DS/ES/FS/GS register sizes in getter/setter for NetBSD. Apparently
only CS and SS registers are specified as 64/32-bit in LLDB, while
the others are specified as 16-bit.

Diff Detail

Event Timeline

mgorny requested review of this revision.Nov 9 2020, 10:31 AM
mgorny created this revision.
krytarowski accepted this revision.Nov 9 2020, 1:00 PM
This revision is now accepted and ready to land.Nov 9 2020, 1:00 PM
Closed by commit rGed3ac6c110a5: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes (authored by mgorny). · Explain WhyNov 9 2020, 1:15 PM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rGed3ac6c110a5: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2020, 1:15 PM

Revision Contents

PathSize
lldb/
source/
Plugins/
Process/
NetBSD/
32 lines

Diff 303968

lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

Show First 20 Lines • Show All 533 Lines • ▼ Show 20 Lines case lldb_rip_x86_64:
break; break;
case lldb_rflags_x86_64: case lldb_rflags_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_RFLAGS]; reg_value = (uint64_t)m_gpr.regs[_REG_RFLAGS];
break; break;
case lldb_cs_x86_64: case lldb_cs_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_CS]; reg_value = (uint64_t)m_gpr.regs[_REG_CS];
break; break;
case lldb_fs_x86_64: case lldb_fs_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_FS]; reg_value = (uint16_t)m_gpr.regs[_REG_FS];
break; break;
case lldb_gs_x86_64: case lldb_gs_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_GS]; reg_value = (uint16_t)m_gpr.regs[_REG_GS];
break; break;
case lldb_ss_x86_64: case lldb_ss_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_SS]; reg_value = (uint64_t)m_gpr.regs[_REG_SS];
break; break;
case lldb_ds_x86_64: case lldb_ds_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_DS]; reg_value = (uint16_t)m_gpr.regs[_REG_DS];
break; break;
case lldb_es_x86_64: case lldb_es_x86_64:
reg_value = (uint64_t)m_gpr.regs[_REG_ES]; reg_value = (uint16_t)m_gpr.regs[_REG_ES];
break; break;
#else #else
case lldb_rax_x86_64: case lldb_rax_x86_64:
reg_value = (uint32_t)m_gpr.r_eax; reg_value = (uint32_t)m_gpr.r_eax;
break; break;
case lldb_rbx_x86_64: case lldb_rbx_x86_64:
reg_value = (uint32_t)m_gpr.r_ebx; reg_value = (uint32_t)m_gpr.r_ebx;
break; break;
Show All 20 Lines case lldb_rip_x86_64:
break; break;
case lldb_rflags_x86_64: case lldb_rflags_x86_64:
reg_value = (uint32_t)m_gpr.r_eflags; reg_value = (uint32_t)m_gpr.r_eflags;
break; break;
case lldb_cs_x86_64: case lldb_cs_x86_64:
reg_value = (uint32_t)m_gpr.r_cs; reg_value = (uint32_t)m_gpr.r_cs;
break; break;
case lldb_fs_x86_64: case lldb_fs_x86_64:
reg_value = (uint32_t)m_gpr.r_fs; reg_value = (uint16_t)m_gpr.r_fs;
break; break;
case lldb_gs_x86_64: case lldb_gs_x86_64:
reg_value = (uint32_t)m_gpr.r_gs; reg_value = (uint16_t)m_gpr.r_gs;
break; break;
case lldb_ss_x86_64: case lldb_ss_x86_64:
reg_value = (uint32_t)m_gpr.r_ss; reg_value = (uint32_t)m_gpr.r_ss;
break; break;
case lldb_ds_x86_64: case lldb_ds_x86_64:
reg_value = (uint32_t)m_gpr.r_ds; reg_value = (uint16_t)m_gpr.r_ds;
break; break;
case lldb_es_x86_64: case lldb_es_x86_64:
reg_value = (uint32_t)m_gpr.r_es; reg_value = (uint16_t)m_gpr.r_es;
break; break;
#endif #endif
case lldb_fctrl_x86_64: case lldb_fctrl_x86_64:
reg_value = (uint16_t)m_xstate.xs_fxsave.fx_cw; reg_value = (uint16_t)m_xstate.xs_fxsave.fx_cw;
break; break;
case lldb_fstat_x86_64: case lldb_fstat_x86_64:
reg_value = (uint16_t)m_xstate.xs_fxsave.fx_sw; reg_value = (uint16_t)m_xstate.xs_fxsave.fx_sw;
break; break;
▲ Show 20 Lines • Show All 213 Lines • ▼ Show 20 Lines case lldb_rip_x86_64:
break; break;
case lldb_rflags_x86_64: case lldb_rflags_x86_64:
m_gpr.regs[_REG_RFLAGS] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_RFLAGS] = reg_value.GetAsUInt64();
break; break;
case lldb_cs_x86_64: case lldb_cs_x86_64:
m_gpr.regs[_REG_CS] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_CS] = reg_value.GetAsUInt64();
break; break;
case lldb_fs_x86_64: case lldb_fs_x86_64:
m_gpr.regs[_REG_FS] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_FS] = reg_value.GetAsUInt16();
break; break;
case lldb_gs_x86_64: case lldb_gs_x86_64:
m_gpr.regs[_REG_GS] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_GS] = reg_value.GetAsUInt16();
break; break;
case lldb_ss_x86_64: case lldb_ss_x86_64:
m_gpr.regs[_REG_SS] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_SS] = reg_value.GetAsUInt64();
break; break;
case lldb_ds_x86_64: case lldb_ds_x86_64:
m_gpr.regs[_REG_DS] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_DS] = reg_value.GetAsUInt16();
break; break;
case lldb_es_x86_64: case lldb_es_x86_64:
m_gpr.regs[_REG_ES] = reg_value.GetAsUInt64(); m_gpr.regs[_REG_ES] = reg_value.GetAsUInt16();
break; break;
#else #else
case lldb_rax_x86_64: case lldb_rax_x86_64:
m_gpr.r_eax = reg_value.GetAsUInt32(); m_gpr.r_eax = reg_value.GetAsUInt32();
break; break;
case lldb_rbx_x86_64: case lldb_rbx_x86_64:
m_gpr.r_ebx = reg_value.GetAsUInt32(); m_gpr.r_ebx = reg_value.GetAsUInt32();
break; break;
Show All 20 Lines case lldb_rip_x86_64:
break; break;
case lldb_rflags_x86_64: case lldb_rflags_x86_64:
m_gpr.r_eflags = reg_value.GetAsUInt32(); m_gpr.r_eflags = reg_value.GetAsUInt32();
break; break;
case lldb_cs_x86_64: case lldb_cs_x86_64:
m_gpr.r_cs = reg_value.GetAsUInt32(); m_gpr.r_cs = reg_value.GetAsUInt32();
break; break;
case lldb_fs_x86_64: case lldb_fs_x86_64:
m_gpr.r_fs = reg_value.GetAsUInt32(); m_gpr.r_fs = reg_value.GetAsUInt16();
break; break;
case lldb_gs_x86_64: case lldb_gs_x86_64:
m_gpr.r_gs = reg_value.GetAsUInt32(); m_gpr.r_gs = reg_value.GetAsUInt16();
break; break;
case lldb_ss_x86_64: case lldb_ss_x86_64:
m_gpr.r_ss = reg_value.GetAsUInt32(); m_gpr.r_ss = reg_value.GetAsUInt32();
break; break;
case lldb_ds_x86_64: case lldb_ds_x86_64:
m_gpr.r_ds = reg_value.GetAsUInt32(); m_gpr.r_ds = reg_value.GetAsUInt16();
break; break;
case lldb_es_x86_64: case lldb_es_x86_64:
m_gpr.r_es = reg_value.GetAsUInt32(); m_gpr.r_es = reg_value.GetAsUInt16();
break; break;
#endif #endif
case lldb_fctrl_x86_64: case lldb_fctrl_x86_64:
m_xstate.xs_fxsave.fx_cw = reg_value.GetAsUInt16(); m_xstate.xs_fxsave.fx_cw = reg_value.GetAsUInt16();
break; break;
case lldb_fstat_x86_64: case lldb_fstat_x86_64:
m_xstate.xs_fxsave.fx_sw = reg_value.GetAsUInt16(); m_xstate.xs_fxsave.fx_sw = reg_value.GetAsUInt16();
break; break;
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines