Broadcase no more input event on EOF in Communication.cpp

[tberghammer]

Summary

Broadcast no more input event on EOF in Communication.cpp

This fixes a dead lock in SynchronizeWithReadThread when the file
descriptor is already at EOF and it is always available for read.

[labath]

The underlying problem here is that if CloseOnEOF is false, and the other end is closed, the read thread will sit in a busy loop continuously trying to read something (and failing). The right solution is to avoid the busy loop altogether.

[tberghammer]

Suggested fix uploaded as D9077

source/Core/Communication.cpp

while (!done && comm->m_read_thread_enabled)
         }
 
         switch (status)
         {
         case eConnectionStatusSuccess:
             break;
 
         case eConnectionStatusEndOfFile:
+            comm->BroadcastEvent (eBroadcastBitNoMorePendingInput);
             if (comm->GetCloseOnEOF())
                  done = true;
              break;
         case eConnectionStatusError:            // Check GetError() for details
             if (error.GetType() == eErrorTypePOSIX && error.GetError() == EIO)
             {
                 // EIO on a pipe is usually caused by remote shutdown
                 comm->Disconnect ();