This is an archive of the discontinued LLVM Phabricator instance.

[llgo] Roll gofrontend to a6e10414311a
ClosedPublic

Authored by pcc on Apr 3 2015, 7:03 PM.

Details

Summary

This takes us to Go 1.4. Also includes a couple of changes to the test
suite, both in the runtime package:

  • Disable TestSetPanicOnFault. We cannot support this scenario at all, due to LLVM's lack of non-call exceptions.
  • Tweak TestFinalizerType. This test only passes with two GC runs.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 23245.Apr 3 2015, 7:03 PM
pcc retitled this revision from to [llgo] Roll gofrontend to a6e10414311a.
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a reviewer: axw.
pcc added a subscriber: Unknown Object (MLST).
axw accepted this revision.Apr 4 2015, 5:18 AM
axw edited edge metadata.

LGTM with minor comment update

libgo-check-failures.diff
57 ↗(On Diff #23245)

Would be good to add a brief explanation that this is due to lack of non-call exception support.

This revision is now accepted and ready to land.Apr 4 2015, 5:18 AM
This revision was automatically updated to reflect the committed changes.