This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers Coverage] Make sancov.py work with wildcards from Windows CMD shell
ClosedPublic

Authored by timurrrr on Mar 31 2015, 9:13 AM.

Details

Reviewers
kcc
timurrrr
Summary

CMD doesn't expand * in command lines, so we have to do it ourselves.

Diff Detail

Event Timeline

timurrrr updated this revision to Diff 22965.Mar 31 2015, 9:13 AM
timurrrr retitled this revision from to [Sanitizers Coverage] Make sancov.py work with wildcards from Windows CMD shell.
timurrrr updated this object.
timurrrr edited the test plan for this revision. (Show Details)
timurrrr added a reviewer: kcc.
timurrrr added a subscriber: Unknown Object (MLST).
kcc edited edge metadata.Mar 31 2015, 10:50 AM

LGTM

Ugh.

lib/sanitizer_common/scripts/sancov.py
187

What about '?'
Why not run glob unconditionally.

timurrrr accepted this revision.Apr 1 2015, 7:48 AM
timurrrr added a reviewer: timurrrr.
timurrrr added inline comments.
lib/sanitizer_common/scripts/sancov.py
187

Good point, will do.

195

the ", bits" part is a merge conflict inflicted mistake indeed/
Will fix

This revision is now accepted and ready to land.Apr 1 2015, 7:48 AM
timurrrr closed this revision.Apr 1 2015, 7:48 AM

r233809.