Page MenuHomePhabricator

Adapt CastExpr::getSubExprAsWritten to ConstantExpr
Needs ReviewPublic

Authored by sberg on Sep 2 2020, 7:30 AM.

Details

Reviewers
rsmith

Diff Detail

Event Timeline

sberg created this revision.Sep 2 2020, 7:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2020, 7:30 AM
sberg requested review of this revision.Sep 2 2020, 7:31 AM
sberg added a comment.Sep 2 2020, 7:33 AM

I hit this with a call to getSubExprAsWriten from the LibreOffice Clang plugin, have no idea whether it can be hit from within the compiler itself. Not sure if clang/unittests/Tooling/CastExprTest.cpp is the best place to add a test for it.

sberg updated this revision to Diff 292728.Sep 18 2020, 2:28 AM

ping

(addressed the clang-tidy nitpick)

sberg added a comment.Fri, Oct 2, 4:58 AM

friendly ping