This is an archive of the discontinued LLVM Phabricator instance.

[mips] [IAS] Improve support for the LI/DLI pseudo-instructions.
AbandonedPublic

Authored by tomatabacu on Mar 25 2015, 7:51 AM.

Details

Reviewers
dsanders
Summary

Changed emission of two consecutive DSLL's of 16 into one DSLL32 of 0,
changed helper function to take the shift amount as an argument and to avoid emitting an ORi if the immediate is 0,
improved error reporting,
made the code clearer, rewrote some comments,
and rewrote a couple of tests.

Diff Detail

Event Timeline

tomatabacu updated this revision to Diff 22650.Mar 25 2015, 7:51 AM
tomatabacu retitled this revision from to [mips] [IAS] Improve support for the LI/DLI pseudo-instructions..
tomatabacu updated this object.
tomatabacu edited the test plan for this revision. (Show Details)
tomatabacu added a reviewer: dsanders.
tomatabacu added a subscriber: Unknown Object (MLST).
dsanders edited edge metadata.Apr 7 2015, 4:05 AM

There seems to be several unrelated changes in this patch. Could you split it up?

tomatabacu abandoned this revision.Apr 10 2015, 8:29 AM

Most of this patch has been split up into: D8924 D8968 D8969 D8973 D8974 and rL234584 rL234595.