This is an archive of the discontinued LLVM Phabricator instance.

Add a test for 'b' (toggle breakpoint)
ClosedPublic

Authored by llunak on Aug 2 2020, 11:39 PM.

Diff Detail

Event Timeline

llunak requested review of this revision.Aug 2 2020, 11:39 PM
llunak created this revision.
llunak updated this revision to Diff 282543.Aug 3 2020, 2:33 AM
llunak edited the summary of this revision. (Show Details)

Removed use of curses python module, lldbexpect hardcodes TERM=vt100, so the escape sequence should be actually hardcoded too. The previous version didn't work e.g. in Linux console.

lldb/test/API is for testing the public LLDB API functions that are exported as lldb::SB*. Not sure this belongs here. There was another patch that was moving things around as well where I commented with the same issue.

clayborg accepted this revision.Aug 4 2020, 5:24 PM

Sounds like it is ok for tests to be here, looks good.

This revision is now accepted and ready to land.Aug 4 2020, 5:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2020, 12:52 AM