This is an archive of the discontinued LLVM Phabricator instance.

Do not assert on POSIXDYLD double-eAdd.
ClosedPublic

Authored by sas on Mar 20 2015, 2:42 PM.

Details

Summary

This has been discovered while experimenting with the gecko linker on android.
In general, assert()'ing on "user input" is a bad idea.

Diff Detail

Repository
rL LLVM

Event Timeline

sas updated this revision to Diff 22379.Mar 20 2015, 2:42 PM
sas retitled this revision from to Do not assert on POSIXDYLD double-eAdd..
sas updated this object.
sas edited the test plan for this revision. (Show Details)
sas added reviewers: clayborg, tfiala.
sas added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 20 2015, 2:43 PM
clayborg edited edge metadata.

lgtm

This revision is now accepted and ready to land.Mar 20 2015, 2:43 PM
This revision was automatically updated to reflect the committed changes.