[lldb-vscode] Make it possible to run vsce package

[rmaz]

Summary

Running vsce package to package lldb-vscode as an installable .vsix file errors with:

ERROR  Invalid publisher name 'llvm.org'. Expected the identifier of a publisher, not its human-friendly name.

This patch fixes the publisher name and bumps a required dependency so that vsce package succeeds.

[clayborg]

lldb/tools/lldb-vscode/package.json

32

is the '^' character meant to be in here?

[rmaz]

lldb/tools/lldb-vscode/package.json

32

Doesn't need to be, indicates to npm install that minor and patch updates versions can be used instead of pinning to a specific version (ie >= 1.36.3 and < 2.0.0).

https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

Fine with either, but would require more frequent patches if the specific version number is pinned.

[clayborg]

LGTM.

[rmaz]

Super. How do I get this landed now, does someone have to commit it manually or does closing the diff take care of it?

[clayborg]

I can land it for you.

[clayborg]

commit 81b79011a77f97798236af6d716e5d352790d54b (HEAD -> master, origin/master, origin/HEAD)
Author: Greg Clayton <[e-mail]>
Date: Thu May 28 13:29:48 2020 -0700

[lldb-vscode] Make it possible to run vsce package

Summary:
Running `vsce package` to package lldb-vscode as an installable .vsix file errors with:

```
ERROR  Invalid publisher name 'llvm.org'. Expected the identifier of a publisher, not its human-friendly name.
```

This patch fixes the publisher name and bumps a required dependency so that `vsce package` succeeds.

Reviewers: clayborg

Reviewed By: clayborg

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D80569

lldb/tools/lldb-vscode/package.json

 {
   "name": "lldb-vscode",
   "displayName": "LLDB native Debug stub",
   "version": "0.1.0",
-  "publisher": "llvm.org",
+  "publisher": "llvm",
+  "repository": "llvm.org",
   "description": "Debug adapter for LLDB which uses a C++ tool to interface directly with LLDB.",
   "author": {
     "name": "Greg Clayton",
     "email": "[e-mail]"
   },
   "license": "LLVM",
   "keywords": [
     "multi-root ready"
   ],
   "engines": {
     "vscode": "^1.18.0",
     "node": "^7.9.0"
   },
-  "icon": "images/lldb.png",
   "categories": [
     "Debuggers"
   ],
   "private": true,
   "devDependencies": {
     "@types/node": "7.0.43",
     "@types/mocha": "2.2.45",
     "typescript": "2.6.2",
     "mocha": "4.0.1",
     "vscode": "1.1.10",
     "vscode-debugadapter-testsupport": "1.25.0",
     "tslint": "5.8.0",
-    "vsce": "1.35.0"
+    "vsce": "^1.36.3"
   },
   "contributes": {
     "debuggers": [
       {
         "type": "lldb-vscode",
         "label": "Native LLDB Debugger",
         "enableBreakpointsFor": {
           "languageIds": [
"debuggers": [
               "program"
             ],
             "properties": {
               "program": {
                 "type": "string",
                 "description": "Path to the program to debug."
               },
               "args": {
-                "type": [ "array", "string" ],
+                "type": [
+                  "array",
+                  "string"
+                ],
                 "description": "Program arguments.",
                 "default": []
               },
               "cwd": {
                 "type": "string",
                 "description": "Program working directory.",
                 "default": "${workspaceRoot}"
               },
"debuggers": [
                 "type": "string",
                 "description": "Triplet of the target architecture to override value derived from the program file."
               },
               "platformName": {
                 "type": "string",
                 "description": "Name of the execution platform to override value derived from the program file."
               },
               "initCommands": {
-                  "type": "array",
-                  "description": "Initialization commands executed upon debugger startup.",
-                  "default": []
               },
               "preRunCommands": {
-                  "type": "array",
-                  "description": "Commands executed just before the program is launched.",
-                  "default": []
               },
               "launchCommands": {
-                  "type": "array",
-                  "description": "Custom commands that are executed instead of launching a process. A target will be created with the launch arguments prior to executing these commands. The commands may optionally create a new target and must perform a launch. A valid process must exist after these commands complete or the \"launch\" will fail.",
-                  "default": []
               },
               "stopCommands": {
-                  "type": "array",
-                  "description": "Commands executed each time the program stops.",
-                  "default": []
               },
               "exitCommands": {
-                  "type": "array",
-                  "description": "Commands executed at the end of debugging session.",
-                  "default": []
               }
             }
           },
           "attach": {
             "properties": {
               "program": {
                 "type": "string",
-                  "description": "Path to the program to attach to."
               },
               "pid": {
                 "type": [
-                    "number",
-                    "string"
                 ],
                 "description": "System process ID to attach to."
               },
               "waitFor": {
                 "type": "boolean",
                 "description": "If set to true, then wait for the process to launch by looking for a process with a basename that matches `program`. No process ID needs to be specified when using this flag.",
                 "default": true
               },