- Complete process load with the common disk file completion, so there is not test provided for it;
- Complete process unload with the tokens of valid loaded images.
Thanks for Raphael's help on the test for process unload.
Differential D79887
[lldb] Tab completion for process load/unload MrHate on May 13 2020, 10:30 AM. Authored by
Details
Thanks for Raphael's help on the test for process unload.
Diff Detail
Event TimelineComment Actions I'm overall very happy with this patch. I have one change request though to prevent that we keep copy-pasting checks like if (m_exe_ctx.HasProcessScope()) around. See my inline comment for that. But beside that and the small typo I pointed out this is good to go.
Comment Actions Maybe we can skip the unified requirements checking now, coz it has got many things to deal with. Comment Actions Can you also add a quick test for process load? Just copy the test_log_dir test but replace the dir completion with file completion (and you can just complete some dummy file, e.g. some empty dummy_file.so you can create in the test directory). Beside that this LGTM.
Comment Actions
Comment Actions
|
Small detail: LLVM comments always have to end with a period '.' like a real sentence. Same with the sentence below.