This is an archive of the discontinued LLVM Phabricator instance.

Differential D79174

[LLDB] Initialize "ThreadPlanTracer::m_thread" to avoid undefined behavior
Needs ReviewPublic

Authored by vangelists on Apr 30 2020, 6:59 AM.

Details

Reviewers
jingham
Summary

The m_thread field of ThreadPlanTracer is not initialized by the constructor leading to undefined behavior in ThreadPlanTracer::GetThread().

Diff Detail

Revision Contents

PathSize
lldb/
source/
Target/
5 lines

Diff 261216

lldb/source/Target/ThreadPlanTracer.cpp

Context not available.
ThreadPlanTracer::ThreadPlanTracer(Thread &thread, lldb::StreamSP &stream_sp) ThreadPlanTracer::ThreadPlanTracer(Thread &thread, lldb::StreamSP &stream_sp)
: m_process(*thread.GetProcess().get()), m_tid(thread.GetID()), : m_process(*thread.GetProcess().get()), m_tid(thread.GetID()),
m_single_step(true), m_enabled(false), m_stream_sp(stream_sp) {} m_single_step(true), m_enabled(false), m_stream_sp(stream_sp),
m_thread(nullptr) {}
ThreadPlanTracer::ThreadPlanTracer(Thread &thread) ThreadPlanTracer::ThreadPlanTracer(Thread &thread)
: m_process(*thread.GetProcess().get()), m_tid(thread.GetID()), : m_process(*thread.GetProcess().get()), m_tid(thread.GetID()),
m_single_step(true), m_enabled(false), m_stream_sp() {} m_single_step(true), m_enabled(false), m_stream_sp(), m_thread(nullptr) {}
Stream *ThreadPlanTracer::GetLogStream() { Stream *ThreadPlanTracer::GetLogStream() {
if (m_stream_sp) if (m_stream_sp)
Context not available.