This is an archive of the discontinued LLVM Phabricator instance.

A Minor change to clang-format-diff.py
ClosedPublic

Authored by eagleoflqj on Apr 12 2020, 8:48 AM.

Reviewers

MyDeveloperDay

Group Reviewers

Restricted Project

Commits

Summary

Testing for None should use the 'is' operator.

LGTM, thank you

This revision is now accepted and ready to land.Apr 12 2020, 10:55 AM

Thanks! I don't have commit access. Somebody please commit it on behalf of me.
name: liumeo
email: liumeo@pku.edu.cn

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

tools/

clang-format/

2 lines

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	def main():

# Extract changed lines for each file.		# Extract changed lines for each file.
filename = None		filename = None
lines_by_file = {}		lines_by_file = {}
for line in sys.stdin:		for line in sys.stdin:
match = re.search(r'^\+\+\+\ (.?/){%s}(\S)' % args.p, line)		match = re.search(r'^\+\+\+\ (.?/){%s}(\S)' % args.p, line)
if match:		if match:
filename = match.group(2)		filename = match.group(2)
if filename == None:		if filename is None:
continue		continue

if args.regex is not None:		if args.regex is not None:
if not re.match('^%s$' % args.regex, filename):		if not re.match('^%s$' % args.regex, filename):
continue		continue
else:		else:
if not re.match('^%s$' % args.iregex, filename, re.IGNORECASE):		if not re.match('^%s$' % args.iregex, filename, re.IGNORECASE):
continue		continue
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines