This is an archive of the discontinued LLVM Phabricator instance.

address review comment
AbandonedPublic

Authored by kiszk on Apr 4 2020, 11:46 AM.

Sorry, I made a mistake. This should not be reviewed. This should be deleted.

kiszk removed a project: Restricted Project.Apr 4 2020, 11:59 AM

kiszk removed a subscriber: cfe-commits.

kiszk abandoned this revision.Apr 5 2020, 8:27 AM

Path

Size

clang-tools-extra/

clang-tidy/

fuchsia/

2 lines

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines	if (const auto *D = Result.Nodes.getNodeAs<CXXRecordDecl>("decl")) {
for (const auto &V : D->vbases()) {		for (const auto &V : D->vbases()) {
const auto *Ty = V.getType()->getAs<RecordType>();		const auto *Ty = V.getType()->getAs<RecordType>();
if (!Ty) continue;		if (!Ty) continue;
const auto *Base = cast<CXXRecordDecl>(Ty->getDecl()->getDefinition());		const auto *Base = cast<CXXRecordDecl>(Ty->getDecl()->getDefinition());
if (!isInterface(Base)) NumConcrete++;		if (!isInterface(Base)) NumConcrete++;
}		}

if (NumConcrete > 1) {		if (NumConcrete > 1) {
diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "		diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");		"pure virtual is discouraged");
}		}
}		}
}		}

} // namespace fuchsia		} // namespace fuchsia
} // namespace tidy		} // namespace tidy
} // namespace clang		} // namespace clang