Page MenuHomePhabricator

Separate monolithic GDBRemoteCommunicationServer class into 4 part
ClosedPublic

Authored by tberghammer on Feb 10 2015, 9:07 AM.

Details

Summary

Separate monolithic GDBRemoteCommunicationServer class into 4 part

GDBRemoteCommunicationServer: Basic packet handling, handler registration
LLDBCommonPacketHandler: Common packet handling for lldb-platform and lldb-gdbserver
LLDBPlatformPacketHandler: lldb-platform specific packet handling
LLGSPacketHandler: lldb-gdbserver specific packet handling

This CL is made to separate the functionality of lldb-platform from lldb-gdbserver in order to make it easier to implement lldb-platform for new target platforms. The CL (in theory) contains no behavioral change.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Separate monolithic GDBRemoteCommunicationServer class into 4 part.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added reviewers: vharron, clayborg.
tberghammer added a subscriber: Unknown Object (MLST).
clayborg requested changes to this revision.Feb 10 2015, 9:48 AM
clayborg edited edge metadata.

Change looks great, I would just like better file names.

I would like to see all classes and files renamed to something like:

LLDBCommonPacketHandler -> GDBRemoteCommunicationServerCommon
LLDBPlatformPacketHandler -> GDBRemoteCommunicationServerPlatform
LLGSPacketHandler -> GDBRemoteCommunicationServerLLGS

This revision now requires changes to proceed.Feb 10 2015, 9:48 AM
tberghammer edited edge metadata.

Rename files as requested

clayborg accepted this revision.Feb 10 2015, 11:16 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Feb 10 2015, 11:16 AM
This revision was automatically updated to reflect the committed changes.