This is an archive of the discontinued LLVM Phabricator instance.

Add invoke statepoint placement tests
ClosedPublic

Authored by igor-laevsky on Feb 10 2015, 7:15 AM.

Details

Summary

Add few simple tests to check statepoint placement for invoke instructions.

Diff Detail

Repository
rL LLVM

Event Timeline

igor-laevsky retitled this revision from to Add invoke statepoint placement tests.
igor-laevsky updated this object.
igor-laevsky edited the test plan for this revision. (Show Details)
igor-laevsky added a reviewer: reames.
igor-laevsky set the repository for this revision to rL LLVM.
igor-laevsky added a subscriber: Unknown Object (MLST).
reames edited edge metadata.Feb 10 2015, 11:54 AM

LGTM with comment addressed.

p.s. Can you add one test for the single entry phi issue? This can be a separate change if that's easier.

test/Transforms/PlaceSafepoints/invokes.ll
4

Remove this please.

igor-laevsky edited edge metadata.

LGTM, shall I commit for you?

artagnon added inline comments.
test/Transforms/PlaceSafepoints/invokes.ll
4

Why did you quote some_call? Doesn't it look ugly?

7

It might be nice to give the test a more descriptive name than testN.

11

Do check for gc.statepoint.<sig>, because you don't know if you're matching a poll or a callsite in the original.

Yes, Philip, please commit on my behalf.

test/Transforms/PlaceSafepoints/invokes.ll
4

My code highlighting tool does a better job for quoted names. But I can remove quotes if you insist.

11

We will check for "invoke" followed by "statepoint". And we don't invoke polls as far as I know. So it must be original call site.

This revision was automatically updated to reflect the committed changes.