This is an archive of the discontinued LLVM Phabricator instance.

Fix comment to more accurately describe C++ language requirements around tail padding.
ClosedPublic

Authored by rsmith on Dec 2 2019, 2:01 PM.

Details

Summary

As of C++ core issue 43 (http://wg21.link/cwg43), which was voted into
the C++ working draft in 1999, it is not permissible to memcpy a base
class subobject, even if it's of POD type, so there is no problem with
reusing the tail padding of a base class. That issue was voted into the
standard in DR status, so it applies retroactively to C++98 (and is in
any case part of C++03).

So stop suggesting that AlwaysUseTailPadding mode is non-conforming.

Diff Detail

Event Timeline

rsmith created this revision.Dec 2 2019, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2019, 2:02 PM
rjmccall accepted this revision.Dec 2 2019, 2:27 PM

LGTM

This revision is now accepted and ready to land.Dec 2 2019, 2:27 PM
This revision was automatically updated to reflect the committed changes.