This is an archive of the discontinued LLVM Phabricator instance.

Make it possible to add the MIR Canonicalizer pass in a pipeline
ClosedPublic

Authored by aditya_nandakumar on Nov 15 2019, 9:41 AM.

Details

Reviewers
plotfi
bogner
Summary

Allow the pass to be added in a pipeline (for debugging purposes).
Alternatively we can separate the MIRCanonicalizer pass into a header, and not need to add the ID here.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2019, 9:41 AM
plotfi requested changes to this revision.Nov 15 2019, 4:17 PM

Any way to test this, or should this just go in as is? If not, LGTM as this is a pretty small change.

This revision now requires changes to proceed.Nov 15 2019, 4:17 PM
plotfi accepted this revision.Nov 15 2019, 4:17 PM
This revision is now accepted and ready to land.Nov 15 2019, 4:17 PM

I don't think there's a way to test this - this needs to be added to a pipeline.