This is an archive of the discontinued LLVM Phabricator instance.

Differential D6902

[lld] Don't fail if parent directory contains a '+' character
ClosedPublic

Authored by garious on Jan 9 2015, 11:26 AM.

Details

Reviewers
shankarke
• shankar.easwaran
Commits
rGfcf77fd369b9: Don't fail if parent directory name contains a '+' character
rLLD225574: Don't fail if parent directory name contains a '+' character
rL225574: Don't fail if parent directory name contains a '+' character
Summary

The test matches the absolute path of a file. If that path contains a '+' character, the test will fail. This patch adds '+' to the list of valid path characters.

Diff Detail

Repository
rL LLVM

Event Timeline

garious updated this revision to Diff 17938.Jan 9 2015, 11:26 AM
garious retitled this revision from to [lld] Don't fail if parent directory contains a '+' character.
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added a reviewer: • shankar.easwaran.
garious set the repository for this revision to rL LLVM.
garious added a project: lld.
garious added a subscriber: Unknown Object (MLST).
shankarke accepted this revision.Jan 9 2015, 5:17 PM
shankarke added a reviewer: shankarke.
This revision is now accepted and ready to land.Jan 9 2015, 5:17 PM
Closed by commit rL225574: Don't fail if parent directory name contains a '+' character (authored by garious). · Explain WhyJan 9 2015, 6:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
test/
elf/
8 lines
2 lines

Diff 17967

lld/trunk/test/elf/dynamic-undef.test

Show All 20 Lines
# Test creation of shared library, this should fail because we are using # Test creation of shared library, this should fail because we are using
# shared option setting the options to use the shared library undefines to # shared option setting the options to use the shared library undefines to
# create undefined atoms from the input shared library # create undefined atoms from the input shared library
RUN: lld -flavor gnu -target x86_64-linux %p/Inputs/tls.x86-64 \ RUN: lld -flavor gnu -target x86_64-linux %p/Inputs/tls.x86-64 \
RUN: %p/Inputs/shared.so-x86-64 -o %t.useundefines -e main -shared \ RUN: %p/Inputs/shared.so-x86-64 -o %t.useundefines -e main -shared \
RUN: --use-shlib-undefines --no-allow-shlib-undefined 2> %t2 RUN: --use-shlib-undefines --no-allow-shlib-undefined 2> %t2
RUN: llvm-readobj -symbols %t.useundefines | FileCheck -check-prefix=SHLIB-UNDEF-SYMBOLS %s RUN: llvm-readobj -symbols %t.useundefines | FileCheck -check-prefix=SHLIB-UNDEF-SYMBOLS %s
EXEC: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts EXEC: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
SHLIB: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts SHLIB: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
EXEC-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo EXEC-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
SHLIB-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo SHLIB-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo
SHLIB-NOUNDEF-NOT: Name: puts SHLIB-NOUNDEF-NOT: Name: puts
SHLIB-UNDEF-SYMBOLS: Name: puts SHLIB-UNDEF-SYMBOLS: Name: puts

lld/trunk/test/elf/filenotfound.test

# Check that a file that cannot be found results in a proper error message # Check that a file that cannot be found results in a proper error message
RUN: not lld -flavor gnu -target x86_64 %p/Inputs/nofile.o 2>&1 | FileCheck %s RUN: not lld -flavor gnu -target x86_64 %p/Inputs/nofile.o 2>&1 | FileCheck %s
#CHECK: lld: cannot find file {{[-_A-Za-z0-9.\\/:]+}}nofile.o #CHECK: lld: cannot find file {{[+-_A-Za-z0-9.\\/:]+}}nofile.o