This is an archive of the discontinued LLVM Phabricator instance.

gn build: use better triple on windows
ClosedPublic

Authored by thakis on Oct 7 2019, 6:07 AM.

Details

Summary

The CMake build uses "x86_64-pc-windows-msvc". The "-msvc" suffix is
important because e.g. clang/test/lit.cfg.py matches against the
suffix "windows-msvc" to compute the presence of the "ms-sdk" and
the absence of the "LP64" feature.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Oct 7 2019, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 6:07 AM
hans accepted this revision.Oct 7 2019, 6:08 AM
This revision is now accepted and ready to land.Oct 7 2019, 6:08 AM
This revision was automatically updated to reflect the committed changes.