This is an archive of the discontinued LLVM Phabricator instance.

NFC: directly return when CommonExitBlock != Succ
ClosedPublic

Authored by hiraditya on Oct 2 2019, 5:12 AM.

Reviewers: None
Commits: rGb1fe6c90e66b: NFC: directly return when CommonExitBlock != Succ
rL373456: NFC: directly return when CommonExitBlock != Succ

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 5:13 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Utils/

6 lines

Show First 20 Lines • Show All 287 Lines • ▼ Show 20 Lines	auto hasNonCommonExitSucc = [&](BasicBlock *Block) {
for (auto *Succ : successors(Block)) {		for (auto *Succ : successors(Block)) {
// Internal edges, ok.		// Internal edges, ok.
if (Blocks.count(Succ))		if (Blocks.count(Succ))
continue;		continue;
if (!CommonExitBlock) {		if (!CommonExitBlock) {
CommonExitBlock = Succ;		CommonExitBlock = Succ;
continue;		continue;
}		}
if (CommonExitBlock == Succ)		if (CommonExitBlock != Succ)
continue;

return true;		return true;
}		}
return false;		return false;
};		};

if (any_of(Blocks, hasNonCommonExitSucc))		if (any_of(Blocks, hasNonCommonExitSucc))
return nullptr;		return nullptr;

return CommonExitBlock;		return CommonExitBlock;
▲ Show 20 Lines • Show All 1,260 Lines • Show Last 20 Lines