Page MenuHomePhabricator

[TestStaticVariables] Mark the one unmarked test let also expectedFailure.
ClosedPublic

Authored by sivachandra on Dec 17 2014, 4:11 PM.

Details

Summary

The test is question here is already annotated
with @expectedFailureDarwin(9980907).

This change also removes an uneccessary (and probably wrong) logic of
byssing few asserts if the compiler is not clang or llvm-gcc.

Both GCC and Clang emit incomplete debug info. Clang emits this:

< 1><0x00000026> DW_TAG_class_type

DW_AT_name                  "A"
DW_AT_byte_size             0x00000001
DW_AT_decl_file             0x00000001
DW_AT_decl_line             0x0000001b

< 2><0x0000002e> DW_TAG_member

DW_AT_name                  "g_points"
DW_AT_type                  <0x0000003b>
DW_AT_decl_file             0x00000001
DW_AT_decl_line             0x0000001e
DW_AT_external              yes(1)
DW_AT_declaration           yes(1)
DW_AT_accessibility         DW_ACCESS_public

< 1><0x0000003b> DW_TAG_array_type

DW_AT_type                  <0x00000046>

< 2><0x00000040> DW_TAG_subrange_type

DW_AT_type                  <0x0000007b>

Notice that the DIE at 0x40 does not specify an upperbound. This is with
Clang-3.5 and Clang ToT.

GCC emits this:

< 1><0x000000aa> DW_TAG_class_type

DW_AT_name                  "A"
DW_AT_byte_size             0x00000001
DW_AT_decl_file             0x00000001
DW_AT_decl_line             0x0000001b
DW_AT_sibling               <0x000000c1>

< 2><0x000000b4> DW_TAG_member

DW_AT_name                  "g_points"
DW_AT_decl_file             0x00000001
DW_AT_decl_line             0x0000001e
DW_AT_type                  <0x000000c1>
DW_AT_external              yes(1)
DW_AT_accessibility         DW_ACCESS_public
DW_AT_declaration           yes(1)

< 1><0x000000c1> DW_TAG_array_type

DW_AT_type                  <0x0000007e>
DW_AT_sibling               <0x000000cc>

< 2><0x000000ca> DW_TAG_subrange_type

The DIE at 0xca is missing attributes. This is with gcc-4.8.2.

Diff Detail

Event Timeline

sivachandra retitled this revision from to [TestStaticVariables] Mark the one unmarked test let also expectedFailure..
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Dec 17 2014, 6:03 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Dec 17 2014, 6:03 PM
sivachandra closed this revision.Dec 19 2014, 2:41 PM