Page MenuHomePhabricator

[X86][AVX] Add SimplifyDemandedVectorElts support for KSHIFTL/KSHIFTR
ClosedPublic

Authored by RKSimon on Wed, Aug 21, 5:31 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Wed, Aug 21, 5:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 21, 5:31 AM
craig.topper added inline comments.Thu, Aug 22, 9:31 AM
lib/Target/X86/X86ISelLowering.cpp
34280 ↗(On Diff #216379)

The RHS should always be a ConstantSDNode. You don't need the dyn_cast. Probably can just assert that it's less the NumElts. We shouldn't form it with out of range values. There's no intrinsic for it. We just use shuffles.

RKSimon updated this revision to Diff 216798.Fri, Aug 23, 4:01 AM

Applied @craig.topper's feedback

This revision is now accepted and ready to land.Fri, Aug 23, 10:03 AM
This revision was automatically updated to reflect the committed changes.