This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizer] Remove unused functions
ClosedPublic

Authored by aganea on Aug 20 2019, 3:48 PM.

Details

Summary

Gcc 7.3 warns these functions are unused. Should we remove them?

[711/3639] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/SanitizerCoverage.cpp.o
/mnt/f/svn/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1028:13: warning: ‘std::__cxx11::string {anonymous}::SanitizerCoverage::getSectionEnd(const string&) const’ defined but not used [-Wunused-function]
 std::string SanitizerCoverage::getSectionEnd(const std::string &Section) const {
             ^~~~~~~~~~~~~~~~~
/mnt/f/svn/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1024:1: warning: ‘std::__cxx11::string {anonymous}::SanitizerCoverage::getSectionStart(const string&) const’ defined but not used [-Wunused-function]
 SanitizerCoverage::getSectionStart(const std::string &Section) const {
 ^~~~~~~~~~~~~~~~~

Diff Detail

Repository
rL LLVM

Event Timeline

aganea created this revision.Aug 20 2019, 3:48 PM
leonardchan accepted this revision.Aug 20 2019, 3:53 PM

Thanks for taking care of this! Sorry for not doing this earlier. Got caught up in other stuff.

This revision is now accepted and ready to land.Aug 20 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.