[Sanitizer] Remove unused functions

[aganea]

Summary

Gcc 7.3 warns these functions are unused. Should we remove them?

[711/3639] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/SanitizerCoverage.cpp.o
/mnt/f/svn/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1028:13: warning: ‘std::__cxx11::string {anonymous}::SanitizerCoverage::getSectionEnd(const string&) const’ defined but not used [-Wunused-function]
 std::string SanitizerCoverage::getSectionEnd(const std::string &Section) const {
             ^~~~~~~~~~~~~~~~~
/mnt/f/svn/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1024:1: warning: ‘std::__cxx11::string {anonymous}::SanitizerCoverage::getSectionStart(const string&) const’ defined but not used [-Wunused-function]
 SanitizerCoverage::getSectionStart(const std::string &Section) const {
 ^~~~~~~~~~~~~~~~~

[leonardchan]

Thanks for taking care of this! Sorry for not doing this earlier. Got caught up in other stuff.

llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp

if (Section == SanCovPCsSectionName)
       return ".SCOVP$M";
     return ".SCOV$GM"; // For SanCovGuardsSectionName.
   }
   if (TargetTriple.isOSBinFormatMachO())
     return "__DATA,__" + Section;
   return "__" + Section;
 }
 
-std::string
-SanitizerCoverage::getSectionStart(const std::string &Section) const {
-  return getSectionStartImpl(TargetTriple, Section);
-}
-
-std::string SanitizerCoverage::getSectionEnd(const std::string &Section) const {
-  return getSectionEndImpl(TargetTriple, Section);
-}
-
 INITIALIZE_PASS(ModuleSanitizerCoverageLegacyPass, "module-sancov",
                 "Pass for inserting sancov top-level initialization calls",
                 false, false)
 
 char SanitizerCoverageLegacyPass::ID = 0;
 INITIALIZE_PASS_BEGIN(SanitizerCoverageLegacyPass, "sancov",
                       "Pass for instrumenting coverage on functions", false,
                       false)