Give a little more info when "run_to_x_breakpoint" fails

[jingham]

Summary

We failure was a little bit terse. Say whether we exited, hit another breakpoint/crashed, etc.

[kwk]

lldb/packages/Python/lldbsuite/test/lldbutil.py

789 ↗

(On Diff #213146)

I think the order of the placeholders is wrong either in the format string or in the arguments. This should work:

test.fail("Stopped for another reason: Breakpoint: %d Signaled: %d Crashed: %d"%(len(bkpts), len(signaled), len(crashed)))

[jingham]

Fixed the inverted call order.

[jingham]

Thanks for pointing that out.

packages/Python/lldbsuite/test/lldbutil.py

     threads = get_threads_stopped_at_breakpoint(
                 process, bkpt)
 
+    # Check that we stopped at our breakpoint.  Try to separate failure reasons:
+    test.assertNotEqual(process.GetState(), lldb.eStateExited, "Process exited before stopping at breakpoint.")
+    if len(threads) == 0:
+        (bkpts, crashed, signaled) = ([], [], [])
+        sort_stopped_threads(process, 
+                             breakpoint_threads = bkpts, 
+                             crashed_threads = crashed, 
+                             signal_threads = signaled)
+        test.fail("Stopped for another reason: Breakpoint: %d Signaled: %d Crashed: %d"%(len(bkpts), len(signaled), len(crashed)))
+
     test.assertTrue(len(threads) == 1, "Expected 1 thread to stop at breakpoint, %d did."%(len(threads)))
+
     thread = threads[0]
     return (target, process, thread, bkpt)