This is an archive of the discontinued LLVM Phabricator instance.

Differential D65431

[lld] Simplify the code in SymbolTable::reportUnresolvable
Needs ReviewPublic

Authored by dongAxis on Jul 29 2019, 10:36 PM.
This revision needs review, but all reviewers have resigned.

Details

Reviewers
MaskRay
Summary

use less code to write code

Diff Detail

Event Timeline

dongAxis created this revision.Jul 29 2019, 10:36 PM
dongAxis retitled this revision from Simplify the code in SymbolTable::reportUnresolvable to [lld] Simplify the code in SymbolTable::reportUnresolvable.
dongAxis set the repository for this revision to rL LLVM.
dongAxis added a subscriber: dongAxis.
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2019, 10:37 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dongAxis added a reviewer: MaskRay.Jul 29 2019, 10:39 PM
MaskRay accepted this revision.EditedJul 29 2019, 10:54 PM

There is actually a newly added isa_and_nonnull. I don't use it because its functionality is covered by dyn_cast_or_null which is more common...

use less code to write code

The title or the description should probably just mention that this patch simplifies a pattern with dyn_cast_or_null.

This revision is now accepted and ready to land.Jul 29 2019, 10:54 PM
MaskRay resigned from this revision.Aug 12 2019, 11:53 PM

Oops, it has more characters so this is not a simplification...

This revision now requires review to proceed.Aug 12 2019, 11:53 PM

Revision Contents

PathSize
COFF/
2 lines

Diff 212273

COFF/SymbolTable.cpp

Context not available.
StringRef name = undef->getName(); StringRef name = undef->getName();
if (name.startswith("__imp_")) { if (name.startswith("__imp_")) {
Symbol *imp = find(name.substr(strlen("__imp_"))); Symbol *imp = find(name.substr(strlen("__imp_")));
if (imp && isa<Defined>(imp)) if (dyn_cast_or_null<Defined>(imp))
continue; continue;
} }
if (name.contains("_PchSym_")) if (name.contains("_PchSym_"))
Context not available.