This is an archive of the discontinued LLVM Phabricator instance.

lld-link: Stop accepting /natvis and /fastfail in .drectve sections
ClosedPublic

Authored by thakis on Jul 8 2019, 9:14 AM.

Reviewers

Commits

Summary

link.exe doesn't accept them either.

LGTM

This revision is now accepted and ready to land.Jul 8 2019, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

trunk/

COFF/

4 lines

Show First 20 Lines • Show All 359 Lines • ▼ Show 20 Lines	case OPT_nodefaultlib:
break;		break;
case OPT_section:		case OPT_section:
parseSection(Arg->getValue());		parseSection(Arg->getValue());
break;		break;
case OPT_subsystem:		case OPT_subsystem:
parseSubsystem(Arg->getValue(), &Config->Subsystem,		parseSubsystem(Arg->getValue(), &Config->Subsystem,
&Config->MajorOSVersion, &Config->MinorOSVersion);		&Config->MajorOSVersion, &Config->MinorOSVersion);
break;		break;
		// Only add flags here that link.exe accepts in
		// `#pragma comment(linker, "/flag")`-generated sections.
case OPT_editandcontinue:		case OPT_editandcontinue:
case OPT_fastfail:
case OPT_guardsym:		case OPT_guardsym:
case OPT_natvis:
case OPT_throwingnew:		case OPT_throwingnew:
break;		break;
default:		default:
error(Arg->getSpelling() + " is not allowed in .drectve");		error(Arg->getSpelling() + " is not allowed in .drectve");
}		}
}		}
}		}

▲ Show 20 Lines • Show All 1,483 Lines • Show Last 20 Lines