Page MenuHomePhabricator

[yaml2obj/obj2yaml] - Make RawContentSection::Info Optional<>
ClosedPublic

Authored by grimar on Tue, Jun 18, 5:21 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Tue, Jun 18, 5:21 AM

Looks good aside from some minor comments. By the way, you don't need the "to be" in the patch title.

test/tools/obj2yaml/implicit-sections-info.yaml
1 ↗(On Diff #205311)

I'm not sure this test needs to be called "implicit-sections-info.yaml". Simply "section-info.yaml" seems like enough.

1 ↗(On Diff #205311)

create Info -> write a section Info

23–24 ↗(On Diff #205311)

Nit: spurious extra spaces between tag and value on these two lines.

tools/yaml2obj/yaml2elf.cpp
490 ↗(On Diff #205311)

There should probably be a blank line before this if, to match the other blocks.

grimar updated this revision to Diff 205332.Tue, Jun 18, 7:07 AM
grimar marked 4 inline comments as done.
grimar retitled this revision from [yaml2obj/obj2yaml] - Make RawContentSection::Info to be Optional<> to [yaml2obj/obj2yaml] - Make RawContentSection::Info Optional<>.
  • Addressed review comments.
This revision is now accepted and ready to land.Tue, Jun 18, 7:10 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptWed, Jun 19, 1:56 AM