This is an archive of the discontinued LLVM Phabricator instance.

SimplifyCFG: Refactor GatherConstantCompares() result in a struct
AbandonedPublic

Authored by mehdi_amini on Nov 19 2014, 9:57 PM.

mehdi_amini retitled this revision from to SimplifyCFG: Refactor GatherConstantCompares() result in a struct.

mehdi_amini updated this object.

mehdi_amini edited the test plan for this revision. (Show Details)

rename match() to matchInstruction() to avoid conflicting with PatternMatchers.h

Add anonymous namespace.

Make setValueOnce() less obscure.

Fix previous diff

Path

Size

lib/

Transforms/

Utils/

7 lines

Context not available.
	return nullptr;	return nullptr;
	}	}

		namespace {

	/// Given a chain of or (\|\|) or and (&&) comparison of a value against a	/// Given a chain of or (\|\|) or and (&&) comparison of a value against a
	/// constant, this will try to recover the information required for a switch	/// constant, this will try to recover the information required for a switch
	/// structure.	/// structure.
Context not available.
	/// it wasn't set before or if the new value is the same as the old one	/// it wasn't set before or if the new value is the same as the old one
	bool setValueOnce(Value *NewVal) {	bool setValueOnce(Value *NewVal) {
	if(CompValue && CompValue != NewVal) return false;	if(CompValue && CompValue != NewVal) return false;
	return CompValue = NewVal;	CompValue = NewVal;
		return (CompVal != nullptr);
	}	}

	/// Try to match Instruction "I" as a comparison against a constant and	/// Try to match Instruction "I" as a comparison against a constant and
Context not available.
	}	}
	};	};

		}

	static void EraseTerminatorInstAndDCECond(TerminatorInst *TI) {	static void EraseTerminatorInstAndDCECond(TerminatorInst *TI) {
	Instruction *Cond = nullptr;	Instruction *Cond = nullptr;
	if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) {	if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) {
Context not available.