Page MenuHomePhabricator

clang-format: never align after 'return' for Java
ClosedPublic

Authored by het on Nov 19 2014, 2:27 PM.

Details

Reviewers
djasper
Summary

Diff Detail

Event Timeline

het updated this revision to Diff 16403.Nov 19 2014, 2:27 PM
het retitled this revision from to clang-format: make alignment after 'return' configurable.
het updated this object.
het edited the test plan for this revision. (Show Details)
het added a reviewer: djasper.
het set the repository for this revision to rL LLVM.
het added a subscriber: Unknown Object (MLST).
djasper edited edge metadata.Nov 19 2014, 2:33 PM

Hm. If you think this is Java-specific, I might be inclined to gate this based on the Style's Language for now. The problem is that each additional configuration flag has a certain amount of cost, e.g. because:

  • Style flags become less discoverable
  • Maintenance increases when ensuring that all combinations of flags work as expected
het updated this revision to Diff 16405.Nov 19 2014, 2:46 PM
het retitled this revision from clang-format: make alignment after 'return' configurable to clang-format: never align after 'return' for Java.
het edited edge metadata.
djasper accepted this revision.Nov 20 2014, 1:55 AM
djasper edited edge metadata.

Submitted as r222424.

This revision is now accepted and ready to land.Nov 20 2014, 1:55 AM
djasper closed this revision.Nov 20 2014, 1:55 AM