Page MenuHomePhabricator

clang-format: ignore C++ keywords in Java
ClosedPublic

Authored by het on Nov 18 2014, 3:31 PM.

Details

Reviewers
djasper
Summary

Before

public void union
(Object o);

public void struct
(Object o);

public void delete (Object o);

After

public void union(Object o);

public void struct(Object o);

public void delete(Object o);

Diff Detail

Event Timeline

het updated this revision to Diff 16354.Nov 18 2014, 3:31 PM
het retitled this revision from to clang-format: ignore C++ keywords in Java.
het updated this object.
het edited the test plan for this revision. (Show Details)
het added a reviewer: djasper.
het set the repository for this revision to rL LLVM.
het added a subscriber: Unknown Object (MLST).
het added a comment.Nov 18 2014, 3:43 PM

Perhaps a more correct way to do this is to transform tok::union, tok::struct, and tok::delete into tok::identifier in the tokenizer if the language is Java

djasper edited edge metadata.Nov 18 2014, 3:45 PM

Yeah, the latter seems preferable.

het updated this revision to Diff 16358.Nov 18 2014, 4:33 PM
het edited edge metadata.
djasper accepted this revision.Nov 19 2014, 6:07 AM
djasper edited edge metadata.

Looks good. I'll submit.

This revision is now accepted and ready to land.Nov 19 2014, 6:07 AM
djasper closed this revision.Nov 19 2014, 6:11 AM

Submitted as r222357.