This is an archive of the discontinued LLVM Phabricator instance.

Properly specify the regex used to match register indexes.
ClosedPublic

Authored by sas on Nov 13 2014, 3:50 PM.

Reviewers

clayborg
tfiala

Commits

Summary

Something like "core:1" would match and try to be interpreted by the following code otherwise.

sas retitled this revision from to Properly specify the regex used to match register indexes..

sas updated this object.

sas edited the test plan for this revision. (Show Details)

sas added reviewers: tfiala, clayborg.

sas added a subscriber: Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.Nov 13 2014, 6:04 PM

Closed by commit rL221980 (authored by @sas).

Path

Size

test/

tools/

lldb-gdbserver/

2 lines

Show First 20 Lines • Show All 728 Lines • ▼ Show 20 Lines	def select_modifiable_register(self, reg_infos):
return alternative_register_index		return alternative_register_index

def extract_registers_from_stop_notification(self, stop_key_vals_text):		def extract_registers_from_stop_notification(self, stop_key_vals_text):
self.assertIsNotNone(stop_key_vals_text)		self.assertIsNotNone(stop_key_vals_text)
kv_dict = self.parse_key_val_dict(stop_key_vals_text)		kv_dict = self.parse_key_val_dict(stop_key_vals_text)

registers = {}		registers = {}
for (key, val) in kv_dict.items():		for (key, val) in kv_dict.items():
if re.match(r"^[0-9a-fA-F]+", key):		if re.match(r"^[0-9a-fA-F]+$", key):
registers[int(key, 16)] = val		registers[int(key, 16)] = val
return registers		return registers

def gather_register_infos(self):		def gather_register_infos(self):
self.reset_test_sequence()		self.reset_test_sequence()
self.add_register_info_collection_packets()		self.add_register_info_collection_packets()

context = self.expect_gdbremote_sequence()		context = self.expect_gdbremote_sequence()
▲ Show 20 Lines • Show All 461 Lines • Show Last 20 Lines