Page MenuHomePhabricator

We need an OptionStore abstraction for storing debug option data.
AbandonedPublic

Authored by beanz on Nov 10 2014, 4:48 PM.

Details

Reviewers
None
Summary

The plan was to have the LLVMContext store option data with the new API and not have this abstraction. Unfortunately as I've begin playing with this that isn't possible.

Not having this abstraction actually means we can't parse command line options directly into their storage because LLVMParseCommandLine will never be able to take an LLVMContext as a parameter-- and it shouldn't.

Having the command line parsing code parse into an LLVMContext would mean libLLVMSupport depending on libLLVMCore, which would be a nasty circular dependency. To prevent that we need an abstraction that can be passed into LLVMParseCommandLine, and can be used by libLLVMSupport without requiring libLLVMCore.

Diff Detail

Event Timeline

beanz updated this revision to Diff 16021.Nov 10 2014, 4:48 PM
beanz retitled this revision from to We need an OptionStore abstraction for storing debug option data..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added a reviewer: chandlerc.
beanz added a subscriber: Unknown Object (MLST).
chandlerc resigned from this revision.Mar 29 2015, 2:11 PM
chandlerc removed a reviewer: chandlerc.

Based on IRC conversations, my impression is this isn't quite the direction being pursued... But can revisit if needed.

beanz abandoned this revision.Mar 30 2015, 10:20 AM