This is an archive of the discontinued LLVM Phabricator instance.

Differential D6177

R220718 broke some unit tests on linux
Needs ReviewPublic

Authored by sbest on Nov 7 2014, 3:58 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

R220718 changed the path libtest.py goes looking for the file "LLDB.h". This will cause all unit tests decorated with "@skipIfNoSBHeaders" to skip the test on linux (and I suspect all non-Apple platforms).

Diff Detail

Event Timeline

sbest updated this revision to Diff 15942.Nov 7 2014, 3:58 PM
sbest retitled this revision from to R220718 broke some unit tests on linux.
sbest updated this object.
sbest edited the test plan for this revision. (Show Details)
sbest added a reviewer: granata.enrico.
sbest added a subscriber: Unknown Object (MLST).
granata.enrico resigned from this revision.Oct 15 2015, 1:33 PM
granata.enrico removed a reviewer: granata.enrico.

Revision Contents

PathSize
test/
5 lines

Diff 15942

test/lldbtest.py

Context not available.
def wrapper(*args, **kwargs): def wrapper(*args, **kwargs):
from unittest2 import case from unittest2 import case
self = args[0] self = args[0]
header = os.path.join(self.lib_dir, 'LLDB.framework', 'Versions','Current','Headers','LLDB.h') if sys.platform.startswith("darwin"):
header = os.path.join(self.lib_dir, 'LLDB.framework', 'Versions','Current','Headers','LLDB.h')
else:
header = os.path.join(os.environ["LLDB_SRC"], "include", "lldb", "API", "LLDB.h")
platform = sys.platform platform = sys.platform
if not os.path.exists(header): if not os.path.exists(header):
self.skipTest("skip because LLDB.h header not found") self.skipTest("skip because LLDB.h header not found")
Context not available.