Add an optional arg to include/exclude synthetic profile when query hasProfileData

[davidxl]

Summary

The arg is defaulted to false as most of the users of the interface checks for branch probability data.

Synthetic profile propagation is not on by default, so this patch has no effect on default compilations.

[eraman]

include/llvm/IR/Function.h

310

To me
return EC.hasValue() && (IncludeSynthetic || !EC.isSynthetic()) looks cleaner and readable, but I'll leave it to you.

[davidxl]

Updated the patch to include more APIs.

[eraman]

Instead of passing a boolean, would it be better to pass ProfileCountType enum? Right now it doesn't make a difference as there are only two valid profile count types, but if that set expands, we could make them like bitmasks and then get a subset match.

[davidxl]

It is tempting to use enum in this case, however I don't see possible extension to the type (in forseable future), so perhaps keep this way.

[davidxl]

Update related interfaces in ProfileSummaryInfo.

include/llvm/IR/Function.h

   ///
   /// Entry count is the number of times the function was executed based on
   /// pgo data.
   ProfileCount getEntryCount() const;
 
   /// Return true if the function is annotated with profile data.
   ///
   /// Presence of entry counts from a profile run implies the function has
-  /// profile annotations.
-  bool hasProfileData() const { return getEntryCount().hasValue(); }
+  /// profile annotations. If IncludeSynthetic is false, only return true
+  /// when the profile data is real.
+  bool hasProfileData(bool IncludeSynthetic = false) const {
+    auto EC = getEntryCount();
+    if (!EC.hasValue() || (EC.isSynthetic() && !IncludeSynthetic))
+      return false;
+    return true;
+  }
 
   /// Returns the set of GUIDs that needs to be imported to the function for
   /// sample PGO, to enable the same inlines as the profiled optimized binary.
   DenseSet<GlobalValue::GUID> getImportGUIDs() const;
 
   /// Set the section prefix for this function.
   void setSectionPrefix(StringRef Prefix);