Page MenuHomePhabricator

Emit OpenCL local global variables without zeorinitializer
ClosedPublic

Authored by arsenm on Nov 2 2014, 4:09 PM.

Details

Reviewers
joey
Summary

Local variables are not initialized, and every target has
been (incorrectly) ignoring the unnecessary request for
zero initialization.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 15678.Nov 2 2014, 4:09 PM
arsenm retitled this revision from to Emit OpenCL local global variables without zeorinitializer .
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
joey accepted this revision.Nov 3 2014, 6:05 AM
joey added a reviewer: joey.
joey added a subscriber: joey.

LGTM! (Apart from those tiny changes)

lib/CodeGen/CGDecl.cpp
196

Use 'Ty' (initialised on line 179)

198

Use 'LTy' (initialised on line 189)

This revision is now accepted and ready to land.Nov 3 2014, 6:05 AM
arsenm closed this revision.Nov 3 2014, 9:03 AM

r221162