creduce-clang-crash: Use `!` instead of `not`

[thakis]

Summary

The run script runs in bash, so no need to depend on llvm's not binary.

[thakis]

This seems to break the script, nevermind!

[akhuang]

Looks good- if we remove not there are a few other things that should be removed

clang/utils/creduce-clang-crash.py

138

also wouldn't need self.is_crash

178

We should remove crash_flag as well

clang/utils/creduce-clang-crash.py

 import shlex
 import tempfile
 import shutil
 from distutils.spawn import find_executable
 
 verbose = False
 creduce_cmd = None
 clang_cmd = None
-not_cmd = None
 
 def verbose_print(*args, **kwargs):
   if verbose:
     print(*args, **kwargs)
 
 def check_file(fname):
   if not os.path.isfile(fname):
     sys.exit("ERROR: %s does not exist" % (fname))
def read_expected_output(self):
     for msg_re in regexes:
       match = re.search(msg_re, crash_output)
       if match:
         msg = match.group(1)
         result = [msg]
         print("Found message:", msg)
 
         if "fatal error:" in msg_re:
           self.is_crash = False
         break
 
     # If no message was found, use the top five stack trace functions,
     # ignoring some common functions
     # Five is a somewhat arbitrary number; the goal is to get a small number
     # of identifying functions with some leeway for common functions
     if not result:
       stacktrace_re = r'[0-9]+\s+0[xX][0-9a-fA-F]+\s*([^(]+)\('
p = subprocess.Popen(self.get_crash_cmd(args=args, filename=filename),
                          stderr=subprocess.STDOUT)
     crash_output, _ = p.communicate()
     return all(msg in crash_output.decode('utf-8') for msg in
                self.expected_output)
 
   def write_interestingness_test(self):
     print("\nCreating the interestingness test...")
 
     crash_flag = "--crash" if self.is_crash else ""
 
-    output = "#!/bin/bash\n%s %s %s >& t.log || exit 1\n" % \
-        (pipes.quote(not_cmd), crash_flag, quote_cmd(self.get_crash_cmd()))
+    output = "#!/bin/bash\n! %s %s >& t.log || exit 1\n" % \
+        (crash_flag, quote_cmd(self.get_crash_cmd()))
 
     for msg in self.expected_output:
       output += 'grep %s t.log || exit 1\n' % pipes.quote(msg)
 
     write_to_script(output, self.testfile)
     self.check_interestingness()
 
   def check_interestingness(self):
except KeyboardInterrupt:
       # Hack to kill C-Reduce because it jumps into its own pgid
       print('\n\nctrl-c detected, killed creduce')
       p.kill()
 
 def main():
   global verbose
   global creduce_cmd
   global clang_cmd
-  global not_cmd
 
   parser = ArgumentParser(description=__doc__,
                           formatter_class=RawTextHelpFormatter)
   parser.add_argument('crash_script', type=str, nargs=1,
                       help="Name of the script that generates the crash.")
   parser.add_argument('file_to_reduce', type=str, nargs=1,
                       help="Name of the file to be reduced.")
   parser.add_argument('--llvm-bin', dest='llvm_bin', type=str,
                       help="Path to the LLVM bin directory.")
-  parser.add_argument('--llvm-not', dest='llvm_not', type=str,
-                      help="The path to the `not` executable. "
-                      "By default uses the llvm-bin directory.")
   parser.add_argument('--clang', dest='clang', type=str,
                       help="The path to the `clang` executable. "
                       "By default uses the llvm-bin directory.")
   parser.add_argument('--creduce', dest='creduce', type=str,
                       help="The path to the `creduce` executable. "
                       "Required if `creduce` is not in PATH environment.")
   parser.add_argument('-v', '--verbose', action='store_true')
   args = parser.parse_args()
 
   verbose = args.verbose
   llvm_bin = os.path.abspath(args.llvm_bin) if args.llvm_bin else None
   creduce_cmd = check_cmd('creduce', None, args.creduce)
   clang_cmd = check_cmd('clang', llvm_bin, args.clang)
-  not_cmd = check_cmd('not', llvm_bin, args.llvm_not)
 
   crash_script = check_file(args.crash_script[0])
   file_to_reduce = check_file(args.file_to_reduce[0])
 
   r = Reduce(crash_script, file_to_reduce)
 
   r.simplify_clang_args()
   r.write_interestingness_test()
   r.clang_preprocess()
   r.run_creduce()
   r.reduce_clang_args()
 
 if __name__ == '__main__':
   main()