This is an archive of the discontinued LLVM Phabricator instance.

Make int type consistent for ASM labels
Needs ReviewPublic

Authored by BrandonTJones on Apr 9 2019, 2:28 AM.

Reviewers

andreadb
grosbach

Summary

Within the ASM parser, the label begins as a 64 byte long int and later gets treated as a 32 byte which can lead to crashes.

Path

Size

llvm/

lib/

MC/

MCParser/

2 lines

test/

MC/

AsmParser/

5 lines

Show First 20 Lines • Show All 1,660 Lines • ▼ Show 20 Lines	if (getTok().getString().empty() \|\| getTok().getString().front() == '\r' \|\|
Out.AddBlankLine();		Out.AddBlankLine();
Lex();		Lex();
return false;		return false;
}		}
// Statements always start with an identifier.		// Statements always start with an identifier.
AsmToken ID = getTok();		AsmToken ID = getTok();
SMLoc IDLoc = ID.getLoc();		SMLoc IDLoc = ID.getLoc();
StringRef IDVal;		StringRef IDVal;
int64_t LocalLabelVal = -1;		int32_t LocalLabelVal = -1;
if (Lexer.is(AsmToken::HashDirective))		if (Lexer.is(AsmToken::HashDirective))
return parseCppHashLineFilenameComment(IDLoc);		return parseCppHashLineFilenameComment(IDLoc);
// Allow an integer followed by a ':' as a directional local label.		// Allow an integer followed by a ':' as a directional local label.
if (Lexer.is(AsmToken::Integer)) {		if (Lexer.is(AsmToken::Integer)) {
LocalLabelVal = getTok().getIntVal();		LocalLabelVal = getTok().getIntVal();
if (LocalLabelVal < 0) {		if (LocalLabelVal < 0) {
if (!TheCondState.Ignore) {		if (!TheCondState.Ignore) {
Lex(); // always eat a token		Lex(); // always eat a token
▲ Show 20 Lines • Show All 4,259 Lines • Show Last 20 Lines

				# RUN: not llvm-mc -triple i386-unknown-unknown %s 2>&1 > /dev/null\| FileCheck %s --check-prefix=CHECK-ERROR


				# CHECK-ERROR: error: unexpected token at start of statement
				0777777777777777: foo