This is an archive of the discontinued LLVM Phabricator instance.

[winasan] Fix strrchr interception with vs2019 CRT
ClosedPublic

Authored by Christopher on Apr 3 2019, 10:19 AM.

Details

Summary

strrchr in vs2019 CRT begins with unrecognized instructions.

VCRUNTIME140!strrchr:
4533c9 xor r9d, r9d
4c8bc1 mov r8, rcx

Diff Detail

Repository
rL LLVM

Event Timeline

Christopher created this revision.Apr 3 2019, 10:19 AM
rnk accepted this revision.Apr 3 2019, 1:30 PM

Thanks for the patch, would you like me to go ahead and land this?

This revision is now accepted and ready to land.Apr 3 2019, 1:30 PM

That would be great if it can be landed, thanks!

rnk added a comment.Apr 4 2019, 2:06 PM

I finished overcoming other VS 2019 installation issues, ran into this issue, and confirmed that this patch fixes it. Thanks!

This revision was automatically updated to reflect the committed changes.