Page MenuHomePhabricator

[InstCombine] Handle vector gep with scalar argument in evaluateInDifferentElementOrder
ClosedPublic

Authored by uabelho on Apr 1 2019, 2:22 AM.

Details

Summary

This fixes PR41270.

The recursive function evaluateInDifferentElementOrder expects to be called
on a vector Value, so when we call it on a vector GEP's arguments, we must
first check that the argument is indeed a vector.

Diff Detail

Repository
rL LLVM

Event Timeline

uabelho created this revision.Apr 1 2019, 2:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2019, 2:22 AM
spatel accepted this revision.Apr 1 2019, 6:00 AM

LGTM, but we can reduce the test (also please use 'utils/update_test_checks.py' to auto-generate the FileCheck lines):

define <4 x i16*> @PR41270([4 x i16]* %x) {
  %ins = insertelement <4 x [4 x i16]*> undef, [4 x i16]* %x, i32 0
  %splat = shufflevector <4 x [4 x i16]*> %ins, <4 x [4 x i16]*> undef, <4 x i32> zeroinitializer
  %t2 = getelementptr inbounds [4 x i16], <4 x [4 x i16]*> %splat, i32 0, i32 3
  %t3 = extractelement <4 x i16*> %t2, i32 3
  %ins2 = insertelement <4 x i16*> undef, i16* %t3, i32 0
  ret <4 x i16*> %ins2
}
This revision is now accepted and ready to land.Apr 1 2019, 6:00 AM

Great! I'll update the test and submit in a little bit.

Thanks!

uabelho updated this revision to Diff 193073.Apr 1 2019, 6:37 AM
uabelho updated this revision to Diff 193079.Apr 1 2019, 6:43 AM
This revision was automatically updated to reflect the committed changes.