Page MenuHomePhabricator

Add flag --enable-check-profile to clang-tidy.
ClosedPublic

Authored by sbenza on Oct 23 2014, 7:33 AM.

Details

Summary

Add flag --enable-check-profile to clang-tidy.
It turns on per-matcher profiles in MatchFinder and prints a report to
stderr at the end.

Diff Detail

Repository
rL LLVM

Event Timeline

sbenza updated this revision to Diff 15329.Oct 23 2014, 7:33 AM
sbenza retitled this revision from to Add flag --enable-check-profile to clang-tidy..
sbenza updated this object.
sbenza edited the test plan for this revision. (Show Details)
sbenza added a reviewer: alexfh.
sbenza added a subscriber: Unknown Object (MLST).
alexfh accepted this revision.Oct 23 2014, 7:55 AM
alexfh edited edge metadata.

Looks good modulo comments.

That's really awesome!

clang-tidy/ClangTidy.cpp
220 ↗(On Diff #15329)

nit: No braces around single-statement if bodies in LLVM style.

clang-tidy/ClangTidyDiagnosticConsumer.h
198 ↗(On Diff #15329)

Unused?

clang-tidy/tool/ClangTidyMain.cpp
287 ↗(On Diff #15329)

nit: Move the if body to the next line.

This revision is now accepted and ready to land.Oct 23 2014, 7:55 AM
sbenza updated this revision to Diff 15330.Oct 23 2014, 9:06 AM
sbenza edited edge metadata.

Minor fixes

clang-tidy/ClangTidy.cpp
220 ↗(On Diff #15329)

done

clang-tidy/ClangTidyDiagnosticConsumer.h
198 ↗(On Diff #15329)

Oops. Remnants of a previous implementation.

clang-tidy/tool/ClangTidyMain.cpp
287 ↗(On Diff #15329)

Fixed.

sbenza closed this revision.Oct 23 2014, 10:34 AM
sbenza updated this revision to Diff 15337.

Closed by commit rL220491 (authored by @sbenza).