[Reproducers] Enable replay from SBRepro

[JDevlieghere]

Summary

Once the SB macros are in place, we should replay the test using that infrastructure.

[davide]

LGTM

lit/Reproducer/Inputs/FileReplay.in

-reproducer status
-run

lit/Reproducer/Inputs/GDBRemoteReplay.in

-reproducer status
-breakpoint set -f simple.c -l 12
-run
-bt
-cont

lit/Reproducer/TestFileRepro.test

 # REQUIRES: system-darwin
 
 # This tests the replaying of GDB remote packets.
 #
 # We issue the same commands and ensure the output is identical to the original
 # process. To ensure we're not actually running the original binary we check
 # that the string "testing" is not printed.
 
 # RUN: %clang %S/Inputs/simple.c -g -o %t.out
-# RUN: %lldb -x -b -s %S/Inputs/FileCapture.in --capture %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
+# RUN: %lldb -x -b -s %S/Inputs/FileCapture.in --capture %t.repro %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
 # RUN: rm %t.out
-# RUN: %lldb -x -b -s %S/Inputs/FileReplay.in --replay %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
+# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
 
 # CAPTURE: testing
 # REPLAY-NOT: testing
 
 # CHECK: Process {{.*}} exited
 
 # CAPTURE: Reproducer is in capture mode.
 # CAPTURE: Reproducer written

lit/Reproducer/TestGDBRemoteRepro.test

 # UNSUPPORTED: system-windows, system-freebsd
 
 # This tests the replaying of GDB remote packets.
 #
 # We issue the same commands and ensure the output is identical to the original
 # process. To ensure we're not actually running the original binary we check
 # that the string "testing" is not printed.
 
 # RUN: %clang %S/Inputs/simple.c -g -o %t.out
-# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteCapture.in --capture %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
-# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteReplay.in --replay %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
+# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteCapture.in --capture %t.repro %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
+# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
 
 # CHECK: Breakpoint 1
 # CHECK: Process {{.*}} stopped
 # CHECK: Process {{.*}} launched
 # CHECK: thread {{.*}} stop reason = breakpoint
 # CHECK: frame {{.*}} simple.c
 
 # CAPTURE: testing
 # REPLAY-NOT: testing
 
 # CHECK: Process {{.*}} resuming
 # CHECK: Process {{.*}} exited
 
 # CAPTURE: Reproducer is in capture mode.
 # CAPTURE: Reproducer written

source/API/SBReproducer.cpp

const char *SBReproducer::Replay(const char *path) {
   }
 
   repro::Loader *loader = repro::Reproducer::Instance().GetLoader();
   if (!loader) {
     error = "unable to get replay loader.";
     return error.c_str();
   }
 
-  // FIXME: Enable the following code once the SB reproducer has landed.
-#if 0
   FileSpec file = loader->GetFile<SBInfo>();
   if (!file) {
     error = "unable to get replay data from reproducer.";
     return error.c_str();
   }
 
   SBRegistry registry;
   registry.Replay(file);
-#endif
 
   return nullptr;
 }
 
 char lldb_private::repro::SBProvider::ID = 0;
 const char *SBInfo::name = "sbapi";
 const char *SBInfo::file = "sbapi.bin";

tools/driver/Driver.cpp

#endif
 
   if (auto *arg = input_args.getLastArg(OPT_replay)) {
     auto arg_value = arg->getValue();
     const char *error = SBReproducer::Replay(arg_value);
     if (error) {
       WithColor::error() << "reproducer replay failed: " << error << '\n';
       return 1;
     }
-    // FIXME: Return once SBReproducer::Replay actually performs the replay.
+    return 0;
   }
 
   SBError error = SBDebugger::InitializeWithErrorHandling();
   if (error.Fail()) {
     WithColor::error() << "initialization failed: " << error.GetCString()
                        << '\n';
     return 1;
   }