Page MenuHomePhabricator

[RegAllocGreedy] Take last chance recoloring into account in split and assign
ClosedPublic

Authored by uabelho on Feb 18 2019, 11:38 PM.

Details

Summary

This is a follow-up to r353988 where tryEvict was extended to take last
chance recoloring into account. Now we do the same thing for trySplit and
tryAssign.

Now we always pass a "FixedRegisters" argument to canEvictInterference and
tryEvict so it doesn't need to have a default value anymore.

The need for this was found long ago in an out-of-tree target.
Unfortunately I don't have a reproducer for an in-tree target.

Diff Detail

Repository
rL LLVM

Event Timeline

uabelho created this revision.Feb 18 2019, 11:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2019, 11:38 PM
Herald added a subscriber: MatzeB. · View Herald Transcript
rudkx accepted this revision.Feb 18 2019, 11:44 PM
rudkx added a subscriber: rudkx.

LGTM. Thanks for following up with this!

This revision is now accepted and ready to land.Feb 18 2019, 11:44 PM
qcolombet accepted this revision.Feb 19 2019, 8:32 AM
This revision was automatically updated to reflect the committed changes.