Page MenuHomePhabricator

Add llvm.experimental.patchpoint.double
AcceptedPublic

Authored by kmod on Oct 8 2014, 9:40 PM.

Details

Reviewers
atrick
Summary

It didn't seem like there was anything special that had to be done besides
just defining the new intrinsic with the different return type.

It seems inelegant to create a new intrinsic for a new return type, but
we're running into a case where we'd like to return a double through a patchpoint
and I'm not sure of a better way to do that.

Diff Detail

Event Timeline

kmod updated this revision to Diff 14626.Oct 8 2014, 9:40 PM
kmod retitled this revision from to Add llvm.experimental.patchpoint.double.
kmod updated this object.
kmod edited the test plan for this revision. (Show Details)
kmod added a reviewer: atrick.
kmod added a subscriber: Unknown Object (MLST).
atrick accepted this revision.Oct 8 2014, 9:45 PM
atrick edited edge metadata.

LGTM. I don't know of a better way to do this.

This revision is now accepted and ready to land.Oct 8 2014, 9:45 PM

If I recall correctly there should be a few places where the return type is hard-coded or assumed to be i64.

kmod updated this revision to Diff 14634.Oct 9 2014, 1:44 AM
kmod edited edge metadata.

Ok, I took a more thorough look for any places that assume that
the return type is void or i64, and I was only able to find this one.