These are necessary when the standalone PSTL is pulled into the standard
library
Details
Diff Detail
- Repository
- rPSTL pstl
- Build Status
Buildable 26799 Build 26798: arc lint + arc unit
Event Timeline
As I understand, this patch adds forward declarations for all internal functions, similarly to "defs" files having declarations for all functions in namespace std. Perhaps the file names should be aligned with the existing files, e.g. glue_algorithm_internal_defs.h etc.
Also the new files are not included anywhere. Will there be a separate patch that uses these files, or they are intended solely for integration into C++ libraries (or even solely libstdc++)? If the latter, perhaps a usage example could be documented somewhere - in the comments or maybe in a separate readme-like file.
include/pstl/internal/parallel_backend_tbb_fwd.h | ||
---|---|---|
11 | The backend API was supposed to be implementation independent. Maybe there should be no "tbb" in the file name? | |
47–50 | Currently, cancel_execution() is a standalone function in namespace par_backend. Is this mismatch intentional or accidental? |
Ignore this version, Intel changed the definitions of most (all?) of these entry points in the version committed to LLVM, will resubmit after fixing signatures
The backend API was supposed to be implementation independent. Maybe there should be no "tbb" in the file name?